[PATCH] D71786: RFC: [Support] On Windows, add optional support for rpmalloc

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added a comment.

In D71786#2123288 <https://reviews.llvm.org/D71786#2123288>, @russell.gallop wrote:

> I notice that the improvements to rpmalloc for LLVM are still under discussion (https://github.com/mjansson/rpmalloc/issues/150) and targetted at rpmalloc v1.4.1.
>
> Is the version in this review based on rpmalloc v1.4.0?


I believe it was based on this commit: https://github.com/mjansson/rpmalloc/commit/5aa754c14645303f12cd147c78da07af95886af6 (29 Nov 2019)

> Is the plan to land this version as it fixes the concurrency issue then update to v1.4.1 to improve memory usage?
> 
> I wonder if it's possible to get this in for LLVM 11. Is it just wanting an okay on the licensing?

I modified the patch to support rpmalloc, snmalloc & mimalloc from a external folder (outside of the LLVM's folder).
In essence, one would need to do:

  F:\git> git clone https://github.com/mjansson/rpmalloc/tree/mjansson/llvm-opt
  F:\git> cd \llvm-project && mkdir build && cd build
  F:\llvm-project\build> cmake -G"Ninja" ../llvm (...) -DLLVM_INTEGRATED_CRT_ALLOC=f:/git/rpmalloc
  -or-
  F:\llvm-project\build> cmake -G"Ninja" ../llvm (...) -DLLVM_INTEGRATED_CRT_ALLOC=f:/git/snmalloc

And that would solve the licencing issue and leave room for better allocator updates along the way. What do you think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71786/new/

https://reviews.llvm.org/D71786