[PATCH] D82867: Fix tail allocation for large static alloca

[Josh Stone via Phabricator via llvm-commits]

cuviper added inline comments.


================
Comment at: llvm/test/CodeGen/X86/stack-clash-large.ll:24-25
 ; CHECK-X86-64-NEXT:	movq	$0, (%rsp)
 ; CHECK-X86-64-NEXT:	cmpq	%r11, %rsp
 ; CHECK-X86-64-NEXT:	jl	.LBB0_1
 ; CHECK-X86-64-NEXT:# %bb.2:
----------------
serge-sans-paille wrote:
> cuviper wrote:
> > I think this condition is also backwards -- in AT&T syntax, this will jump when %rsp<%r11, which is immediately false.
> this could even be a `jne`, I guess.
Yeah, `jne` should work. Maybe rename `FinalStackPtr` to something like `FinalStackProbe` too, so it's clear that doesn't include the remainder.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82867/new/

https://reviews.llvm.org/D82867