[PATCH] D82867: Fix tail allocation for large static alloca
    serge via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Jun 30 11:56:51 PDT 2020
    
    
  
serge-sans-paille marked an inline comment as done.
serge-sans-paille added inline comments.
================
Comment at: llvm/test/CodeGen/X86/stack-clash-large.ll:24-25
 ; CHECK-X86-64-NEXT:	movq	$0, (%rsp)
 ; CHECK-X86-64-NEXT:	cmpq	%r11, %rsp
 ; CHECK-X86-64-NEXT:	jl	.LBB0_1
 ; CHECK-X86-64-NEXT:# %bb.2:
----------------
cuviper wrote:
> I think this condition is also backwards -- in AT&T syntax, this will jump when %rsp<%r11, which is immediately false.
this could even be a `jne`, I guess.
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82867/new/
https://reviews.llvm.org/D82867
    
    
More information about the llvm-commits
mailing list