[PATCH] D82601: [FileCheck] Permit multiple -v or -vv

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D82601#2119199 <https://reviews.llvm.org/D82601#2119199>, @jhenderson wrote:

> I personally recommend that style these days as a slight readability improvement. I don't think there's any particular widespread agreement on what is the best way though, and wouldn't ask for mass changes in existing tests. The idea is that from the line with the pipe on, you can tell that the complete command is written on that line, and that the next line will be a continuation, whilst the next line's extra 2 spaces of indentation show that it's a continuation from the previous line (and since it starts with a command is the start of that command). The alternative approach of the pipe being on the next line requires people to look at the next line to confirm whether or not all the command's arguments have been included.


Thanks for the reminder.  At the very least, this style seems consistent with other styles I've seen in LLVM.  For example, before LLVM, I was used to the following style for operators in C/C++:

  if (very_long_cond_1
      && very_long_cond2)
    statement;

But LLVM's style is:

  if (very_long_cond_1 &&
      very_long_cond_2)
    statement;


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82601/new/

https://reviews.llvm.org/D82601