[PATCH] D82601: [FileCheck] Permit multiple -v or -vv

Mon Jun 29 00:29:37 PDT 2020

jhenderson accepted this revision.
jhenderson added a comment.

In D82601#2117151 <https://reviews.llvm.org/D82601#2117151>, @jdenny wrote:

> @jhenderson, @thopre Thanks for the quick reviews!
>
> > Strange to have the pipe at the end but if that's the agreed upon practice so be it.
>
> Well, a reviewer requested it at least once.  @jhenderson, wasn't that you?  Should we come to a broader consensus about this style, at least for FileCheck's test suite?
>
> I don't think that point should delay these patches, but I'd be happy to go back and revise if we arrive at a different conclusion.

I personally recommend that style these days as a slight readability improvement. I don't think there's any particular widespread agreement on what is the best way though, and wouldn't ask for mass changes in existing tests. The idea is that from the line with the pipe on, you can tell that the complete command is written on that line, and that the next line will be a continuation, whilst the next line's extra 2 spaces of indentation show that it's a continuation from the previous line (and since it starts with a command is the start of that command). The alternative approach of the pipe being on the next line requires people to look at the next line to confirm whether or not all the command's arguments have been included.

LGTM.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82601/new/

https://reviews.llvm.org/D82601