[PATCH] D82405: [openmp] Move Directive and Clause helper function to tablegen
Joel E. Denny via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 29 15:32:31 PDT 2020
jdenny added inline comments.
================
Comment at: llvm/test/TableGen/directive2.td:63
+// IMPL-NEXT: .Case("dira",TDLD_dira)
+// IMPL-NEXT: .Default(TDLD_dira);
+// IMPL-NEXT: }
----------------
clementval wrote:
> jdenny wrote:
> > Why did `.Default` just show up here in this update?
> I forced to have at least one default now so this reflect here as well.
Before this update (Diff 7) to this review, `TDLD_dira` and `TDLC_clauseb` were already set as defaults, but `.Default` didn't show up in these switches. Was the test case broken, or did something subtle change in the emitter?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82405/new/
https://reviews.llvm.org/D82405
More information about the llvm-commits
mailing list