[PATCH] D82405: [openmp] Move Directive and Clause helper function to tablegen

Mon Jun 29 16:06:27 PDT 2020

clementval marked 3 inline comments as done.
clementval added inline comments.

================
Comment at: llvm/test/TableGen/directive2.td:63
+// IMPL-NEXT:      .Case("dira",TDLD_dira)
+// IMPL-NEXT:      .Default(TDLD_dira);
+// IMPL-NEXT:  }
----------------
jdenny wrote:
> clementval wrote:
> > jdenny wrote:
> > > Why did `.Default` just show up here in this update?
> > I forced to have at least one default now so this reflect here as well. 
> Before this update (Diff 7) to this review, `TDLD_dira` and `TDLC_clauseb` were already set as defaults, but `.Default` didn't show up in these switches.  Was the test case broken, or did something subtle change in the emitter?
The test was not correct. Default should be present as a default is mandatory by the emitter.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82405/new/

https://reviews.llvm.org/D82405