[PATCH] D82520: [Power10] Implement Vector Splat Immediate Builtins in LLVM/Clang

[Biplob Mishra via Phabricator via llvm-commits]

biplmish marked 2 inline comments as done.
biplmish added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:1477
   case PPCISD::XXSPLT:          return "PPCISD::XXSPLT";
+  case PPCISD::XXSPLTI_SP_TO_DP:
+                                return "PPCISD::XXSPLTI_SP_TO_DP";
----------------
amyk wrote:
> This PPCISD node is not used anywhere?
This is used in XXSPLTIDP. The input to builtin is a single precision float which needs to be converted to a double precision for the input xxspltidp


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:588
+
+  def : Pat<(int_ppc_vsx_xxspltiw timm:$A),
+            (XXSPLTIW $A)>;
----------------
amyk wrote:
> There's a section for anonymous patterns at the bottom of the file. It may be better to have a separate `PrefixInstrs` anonymous patterns section there.
Can implement on these lines.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82520/new/

https://reviews.llvm.org/D82520