[PATCH] D81850: [AArch64][SVE] NFCI: Choose consistent naming for predicated SDAG nodes

Sat Jun 27 01:26:43 PDT 2020

paulwalker-arm accepted this revision.
paulwalker-arm added inline comments.
This revision is now accepted and ready to land.

================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1347
+    break;
+    MAKE_CASE(AArch64ISD::CALL)
+    MAKE_CASE(AArch64ISD::ADRP)
----------------
Should these be aligned with the case statements? Although I guess this is just where clang-format wants to put them?

================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.h:32
+//
+//    _MERGE_OP0
+//    _MERGE_OP1
----------------
With the DUP change, can you remove _MERGE_OP0 when pushing the patch.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81850/new/

https://reviews.llvm.org/D81850