[PATCH] D81850: [AArch64][SVE] NFCI: Choose consistent naming for predicated SDAG nodes

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 14:08:46 PDT 2020


sdesmalen updated this revision to Diff 273832.
sdesmalen retitled this revision from "[AArch64][SVE] NFC: Choose consistent naming for predicated SDAG nodes" to "[AArch64][SVE] NFCI: Choose consistent naming for predicated SDAG nodes".
sdesmalen edited the summary of this revision.
sdesmalen added a comment.

Following offline discussion with @paulwalker-arm, I've renamed `DUP_MERGE_OP0` to `DUP_MERGE_PASSTHRU` and changed order of its operands to take the predicate as the first operand, which is more in line with the other predicated nodes. This consistency is useful for lowering to predidcated ops, like done in D82483 <https://reviews.llvm.org/D82483>. This means the patch isn't strictly NFC anymore though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81850/new/

https://reviews.llvm.org/D81850

Files:
  llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.h
  llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td
  llvm/lib/Target/AArch64/SVEInstrFormats.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81850.273832.patch
Type: text/x-patch
Size: 135423 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200626/35acba9f/attachment-0001.bin>


More information about the llvm-commits mailing list