[PATCH] D82405: [openmp] Move Directive and Clause helper function to tablegen

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 17:21:10 PDT 2020


clementval added a comment.

In D82405#2117918 <https://reviews.llvm.org/D82405#2117918>, @jdenny wrote:

> It would still be nice to see the normal C++ indentation in the generated file and in the test suite.  As I said, that could go in a separate patch.
>
> Otherwise, this LGTM.  Please give others a few more days to review, especially given the discussion about splitting the .inc file.


Sure, I don't mind adding the indentation here or in a follow up. About the file splitting I would be in favor to split in at least two files but with no string opinion as said before. What about you @jdenny, @jdoerfert


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82405/new/

https://reviews.llvm.org/D82405





More information about the llvm-commits mailing list