[PATCH] D82405: [openmp] Move Directive and Clause helper function to tablegen

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 14:41:47 PDT 2020


jdenny accepted this revision.
jdenny added a comment.
This revision is now accepted and ready to land.

It would still be nice to see the normal C++ indentation in the generated file and in the test suite.  As I said, that could go in a separate patch.

Otherwise, this LGTM.  Please give others a few more days to review, especially given the discussion about splitting the .inc file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82405/new/

https://reviews.llvm.org/D82405





More information about the llvm-commits mailing list