[PATCH] D82670: [AArch64][SVE] Bail out of performPostLD1Combine for scalable types

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 15:10:48 PDT 2020


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

I was looking into this too; looks like you beat me to it. :)

LGTM with a minor comment on the test.



================
Comment at: llvm/test/CodeGen/AArch64/sve-ld-post-inc.ll:8
+define <vscale x 4 x i32> @test_post_ld1_insert(i32* %a, i32** %ptr, i64 %inc) {
+; CHECK-LABEL: test_post_ld1_insert:
+  %load = load i32, i32* %a
----------------
Please add CHECK lines for the actual load/arithmetic you expect to be generated, even if they aren't really "important" to the crash.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82670/new/

https://reviews.llvm.org/D82670





More information about the llvm-commits mailing list