[PATCH] D75815: [InstCombine] Simplify calls with "returned" attribute

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 12:02:17 PDT 2020


jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:4569
 
+  if (!Call.use_empty() && !Call.isMustTailCall())
+    if (Value *ReturnedArg = Call.getReturnedArgOperand())
----------------
lebedev.ri wrote:
> nickdesaulniers wrote:
> > re: https://bugs.llvm.org/show_bug.cgi?id=46463
> > 
> > Do we need to check that the callee doesn't have the `noinline` function attribute?
> I'm not sure i understand why presence of `noinline` should block this?
> `noipa` on the other hand, sure.
> I'm not sure i understand why presence of noinline should block this?
> noipa on the other hand, sure.

+1 (a little more detail: https://reviews.llvm.org/D75815#1976892)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75815/new/

https://reviews.llvm.org/D75815





More information about the llvm-commits mailing list