[PATCH] D82030: [PowerPC][AIX] Enable base-pointer.

[Zarko Todorovski via Phabricator via llvm-commits]

ZarkoCA accepted this revision.
ZarkoCA added a comment.
This revision is now accepted and ready to land.

I think this one is good. I wonder if there should be more tests to check corrected alignment of various allocations but that seems out of scope for the patch and the tests in https://reviews.llvm.org/D72454 covered that anyway.



================
Comment at: llvm/test/CodeGen/PowerPC/aix-base-pointer.ll:10
+; - stack frame is allocated with correct alignment.
+; - Address of %AlignedBuffer is calculted based off offset from the stack
+;   pointer.
----------------
typo: calculated


================
Comment at: llvm/test/CodeGen/PowerPC/aix-base-pointer.ll:22
+
+; 32BIT-LABEL: .caller:
+; 32BIT:         stw 30, -8(1)
----------------
nit: align these with the line below?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82030/new/

https://reviews.llvm.org/D82030