[PATCH] D82366: [yaml2obj] - Support reading a content as an array of bytes using the new 'ContentArray' key.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 10:23:10 PDT 2020


MaskRay accepted this revision.
MaskRay added a comment.

In D82366#2116205 <https://reviews.llvm.org/D82366#2116205>, @jhenderson wrote:

> Thinking about it further, I think the ContentArray approach is fine by me - I don't see a massive benefit to explicitly specifying the width of fields. I think the ability to provide a string to write could prove useful for writing string tables (see the various examples where the string table contents are hand-written), but I think that might want to be a separate change, perhaps with a `ContentString` field instead? LGTM, but please wait for @MaskRay. I don't have any real objections to his approach either.


A separate `ContentString` assumes the content is a string array. To represent malformed section contents, e.g. broken .eh_frame or other .debug_* , it may be handy to mix strings with int8/int16/int32 literals.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82366/new/

https://reviews.llvm.org/D82366





More information about the llvm-commits mailing list