[PATCH] D82366: [yaml2obj] - Support reading a content as an array of bytes using the new 'ContentArray' key.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 26 01:36:35 PDT 2020
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
Thinking about it further, I think the ContentArray approach is fine by me - I don't see a massive benefit to explicitly specifying the width of fields. I think the ability to provide a string to write could prove useful for writing string tables (see the various examples where the string table contents are hand-written), but I think that might want to be a separate change, perhaps with a `ContentString` field instead? LGTM, but please wait for @MaskRay. I don't have any real objections to his approach either.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82366/new/
https://reviews.llvm.org/D82366
More information about the llvm-commits
mailing list