[PATCH] D82601: [FileCheck] Permit multiple -v or -vv

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 08:44:41 PDT 2020


jdenny added a comment.

@jhenderson, @thopre Thanks for the quick reviews!

> Strange to have the pipe at the end but if that's the agreed upon practice so be it.

Well, a reviewer requested it at least once.  @jhenderson, wasn't that you?  Should we come to a broader consensus about this style, at least for FileCheck's test suite?

I don't think that point should delay these patches, but I'd be happy to go back and revise if we arrive at a different conclusion.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82601/new/

https://reviews.llvm.org/D82601





More information about the llvm-commits mailing list