[PATCH] D82655: [CodeGen] Fix up warnings in visitEXTRACT_SUBVECTOR

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 06:30:53 PDT 2020


david-arm added a comment.

Please note that I tried my best to find tests that exposed the change in behaviour where I added the fixed length vector check, but to no avail! I put that extra check in anyway as I think the optimisation makes no sense for scalable vector types. All we're doing here is removing an infrequently used (I looked for fixed length vector types hitting this path and there weren't many) optimisation for scalable vector types, so I think so long as no existing tests break it should be ok.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82655/new/

https://reviews.llvm.org/D82655





More information about the llvm-commits mailing list