[PATCH] D79709: [AArch64][BFloat] basic AArch64 bfloat support
Cullen Rhodes via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 26 06:30:52 PDT 2020
c-rhodes added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:135
addRegisterClass(MVT::f16, &AArch64::FPR16RegClass);
+ addRegisterClass(MVT::bf16, &AArch64::FPR16RegClass);
addRegisterClass(MVT::f32, &AArch64::FPR32RegClass);
----------------
Shouldn't this and the types below be predicated on `Subtarget->hasBF16()`?
We've been fixing up cases in SVE for bfloat intrinsics where we missed predicating intrinsics / patterns on `+bf16`. I fixed this for the sizeless bfloat types added here in D82494 and it revealed the places we'd forgot to add the guard.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79709/new/
https://reviews.llvm.org/D79709
More information about the llvm-commits
mailing list