[PATCH] D82610: [compiler-rt] Add support for arm64 macOS

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 25 16:56:43 PDT 2020


dexonsmith accepted this revision.
dexonsmith added a comment.

LGTM, after you fix the nits I mention inline.



================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cpp:175
   unsigned struct_stat64_sz = sizeof(struct stat64);
 #endif // !SANITIZER_IOS
   unsigned struct_rusage_sz = sizeof(struct rusage);
----------------
You missed updating this `#endif` comment to match the new `#if` condition.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cpp:202
   unsigned struct_statfs64_sz = sizeof(struct statfs64);
 #endif // SANITIZER_MAC && !SANITIZER_IOS
 
----------------
You missed updating this `#endif` comment to match the new `#if` condition.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82610/new/

https://reviews.llvm.org/D82610





More information about the llvm-commits mailing list