[PATCH] D82610: [compiler-rt] Add support for arm64 macOS

[Steven Wu via Phabricator via llvm-commits]

steven_wu created this revision.
steven_wu added reviewers: arphaman, doug.gregor, dexonsmith.
Herald added subscribers: Sanitizers, danielkiss, ributzka, jkorous, kristof.beyls, mgorny, dberris.
Herald added a project: Sanitizers.
arphaman accepted this revision.
This revision is now accepted and ready to land.
dexonsmith accepted this revision.
dexonsmith added a comment.

LGTM, after you fix the nits I mention inline.



================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cpp:175
   unsigned struct_stat64_sz = sizeof(struct stat64);
 #endif // !SANITIZER_IOS
   unsigned struct_rusage_sz = sizeof(struct rusage);
----------------
You missed updating this `#endif` comment to match the new `#if` condition.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cpp:202
   unsigned struct_statfs64_sz = sizeof(struct statfs64);
 #endif // SANITIZER_MAC && !SANITIZER_IOS
 
----------------
You missed updating this `#endif` comment to match the new `#if` condition.


Allow compiler-rt to build for arm64 support on macOS.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D82610

Files:
  compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake
  compiler-rt/cmake/builtin-config-ix.cmake
  compiler-rt/lib/sanitizer_common/sanitizer_platform_interceptors.h
  compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82610.273550.patch
Type: text/x-patch
Size: 5496 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200625/f90da8ee/attachment.bin>