[PATCH] D82437: [ELF] Add --dependency-file option

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a subscriber: mcgrathr.
MaskRay added inline comments.


================
Comment at: lld/ELF/Driver.cpp:1591
+        unsigned j = i;
+        while (j > 0 && nativePath[--j] == '\\')
+          os << '\\';
----------------
MaskRay wrote:
> The backslash escaping rule is complex. Do you have a description how it works? We should have a test as well. If it can cause problems on Windows, add `UNSUPPORTED: system-windows`
@mcgrathr https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=f37b21b481a7804a13c5806098c19b6119288ba4 does not escape `$` or `\`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82437/new/

https://reviews.llvm.org/D82437