[PATCH] D82437: [ELF] Add --dependency-file option

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 25 10:14:09 PDT 2020


MaskRay added inline comments.


================
Comment at: lld/ELF/Driver.cpp:1591
+        unsigned j = i;
+        while (j > 0 && nativePath[--j] == '\\')
+          os << '\\';
----------------
The backslash escaping rule is complex. Do you have a description how it works? We should have a test as well. If it can cause problems on Windows, add `UNSUPPORTED: system-windows`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82437/new/

https://reviews.llvm.org/D82437





More information about the llvm-commits mailing list