[PATCH] D82541: [AArch64] Emit warning when disassembling unpredictable LDRAA and LDRAB

[David Spickett via Phabricator via llvm-commits]

DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/AArch64/Disassembler/AArch64Disassembler.cpp:1511
+  unsigned Rt = fieldFromInstruction(insn, 0, 5);
+  unsigned Rn = fieldFromInstruction(insn, 5, 5);
+  uint64_t offset = fieldFromInstruction(insn, 22, 1) << 9 |
----------------
vhscampos wrote:
> DavidSpickett wrote:
> > This should be 5, 9. I presume the tests pass because they all use x0.
> Are you sure? The third argument is the number of bits to be read.
Yes you're right, just happened that the numbers lined up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82541/new/

https://reviews.llvm.org/D82541