[PATCH] D81050: [llvm-exegesis] Let Counter returns up to 16 entries.

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo marked an inline comment as done.
oontvoo added inline comments.


================
Comment at: llvm/tools/llvm-exegesis/lib/Target.cpp:118
+    InstructionBenchmark::ResultAggregationModeE ResultAggMode) const {
+  return std::make_unique<UopsBenchmarkRunner>(State, ResultAggMode);
 }
----------------
courbet wrote:
> I the default Target implementation does not use it, let's just do:
> 
> ```
> std::unique_ptr<BenchmarkRunner> ExegesisTarget::createUopsBenchmarkRunner(
>     const LLVMState &State,
>     InstructionBenchmark::ResultAggregationModeE /*unused*/) const {
>   return std::make_unique<UopsBenchmarkRunner>(State);
> }
> ```
Should we change the impl to use it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81050/new/

https://reviews.llvm.org/D81050