[PATCH] D81050: [llvm-exegesis] Let Counter returns up to 16 entries.

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 25 00:29:55 PDT 2020


courbet added inline comments.


================
Comment at: llvm/tools/llvm-exegesis/lib/Target.cpp:118
+    InstructionBenchmark::ResultAggregationModeE ResultAggMode) const {
+  return std::make_unique<UopsBenchmarkRunner>(State, ResultAggMode);
 }
----------------
I the default Target implementation does not use it, let's just do:

```
std::unique_ptr<BenchmarkRunner> ExegesisTarget::createUopsBenchmarkRunner(
    const LLVMState &State,
    InstructionBenchmark::ResultAggregationModeE /*unused*/) const {
  return std::make_unique<UopsBenchmarkRunner>(State);
}
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81050/new/

https://reviews.llvm.org/D81050





More information about the llvm-commits mailing list