[PATCH] D81416: [LV][SLP] Interleave to expose ILP for small loops with scalar reductions.

Thu Jun 25 06:53:28 PDT 2020

spatel added a comment.

In D81416#2112690 <https://reviews.llvm.org/D81416#2112690>, @AaronLiu wrote:

> In order for "this patch to show *the diff* in IR for the proposed code change" and "easily tell what is changing by comparing 2 different files" in this patch, **can you please remove the file you added?**

I did that here:
rGc336f21 <https://reviews.llvm.org/rGc336f21af50a7d493fc521c624e4cbc1eea2849f>

> I will add "PhaseOrdering/interleave_LV_SLP_false.ll" which will be "-interleave-small-loop-scalar-reduction=false", and compare with current  "PhaseOrdering/interleave_LV_SLP.ll" which is "-interleave-small-loop-scalar-reduction=true".
> 
> So we can compare everything in one patch, instead of two patches?

Usually, we add another "RUN" line + FileCheck prefix to a file to show the output differences for a given test when toggling a command-line parameter. I'm not sure why this case is different, but somebody more familiar with LoopVectorize should continue this review.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81416/new/

https://reviews.llvm.org/D81416