[PATCH] D82509: [IR] Delete llvm::Constants using the correct type.

[Eli Friedman via Phabricator via llvm-commits]

efriedma created this revision.
efriedma added reviewers: jdoerfert, spatel, rnk, george.burgess.iv, chandlerc.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.

In most cases, this doesn't have much impact: the destructors just call the base class destructor anyway.  A few subclasses of ConstantExpr actually store non-trivial data, though. Make sure we clean up appropriately.

This is sort of ugly, but I don't see a good alternative given the constraints.

Issue found by asan buildbots running the testcase for D80330 <https://reviews.llvm.org/D80330>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D82509

Files:
  llvm/include/llvm/IR/Constant.h
  llvm/include/llvm/IR/Constants.h
  llvm/lib/Bitcode/Reader/ValueList.cpp
  llvm/lib/IR/Constants.cpp
  llvm/lib/IR/ConstantsContext.h
  llvm/lib/IR/Value.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82509.273188.patch
Type: text/x-patch
Size: 9712 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200624/8aa85de4/attachment.bin>