[PATCH] D82203: [FileCheck] Implement -dump-input-context and -dump-input-filter
Joel E. Denny via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 24 09:43:08 PDT 2020
jdenny marked 2 inline comments as done.
jdenny added inline comments.
================
Comment at: llvm/utils/FileCheck/FileCheck.cpp:138
+ "input lines after any annotation notes, such as error\n"
+ "diagnostics and fuzzy matches. Defaults to 5.\n"));
+
----------------
jdenny wrote:
> arsenm wrote:
> > Does the description need to explicitly call out the default? I would expect that to be part of the standard opt dump, and it would avoid it getting out of sync with the actual value
> -help isn't printing it. Am I doing something wrong?
This comment should be moot now that we're accepting multiple instances of the option and selecting the most informative/verbose value.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82203/new/
https://reviews.llvm.org/D82203
More information about the llvm-commits
mailing list