[PATCH] D82203: [FileCheck] Implement -dump-input-context and -dump-input-filter

[Joel E. Denny via Phabricator via llvm-commits]

jdenny updated this revision to Diff 273059.
jdenny edited the summary of this revision.
jdenny added reviewers: mehdi_amini, SjoerdMeijer, thopre, jhenderson, arsenm, rsmith, lattner, jdoerfert, ctetreau, gargaroff, probinson, aartbik, eugenis, jpienaar, aeubanks.
jdenny set the repository for this revision to rG LLVM Github Monorepo.
jdenny added a comment.
Herald added a subscriber: wdng.

Thanks for the feedback so far.  This is ready for a detailed review now.  I've made the following changes:

- I've updated/extended FileCheck's test suite.
- `-dump-input-filter` still defaults to `error` when `-dump-input=fail` (the default for `-dump-input`).  However, it now defaults to `all` when `-dump-input=always`.  The reason is that `-dump-input=always` is specifically useful for producing an input dump when there's no error, but `-dump-input-filter=error` always elides the entire input in that case.
- `-dump-input-filter` and `-dump-input-context` can now be specified multiple times, and the value that requests the most informative/verbose input dump has precedence.  This mimics the existing `-dump-input` behavior, which has proven to be useful when a test author specifies one of these options in a test case but a test runner specifies the same option with a different value in `FILECHECK_OPTS`.

I've added many reviewers to make sure people who've participated in this discussion previously have a chance to comment.  I apologize if I'm spamming or missing anyone.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82203/new/

https://reviews.llvm.org/D82203

Files:
  llvm/test/FileCheck/dump-input-annotations.txt
  llvm/test/FileCheck/dump-input-context.txt
  llvm/test/FileCheck/dump-input-enable.txt
  llvm/test/FileCheck/dump-input-filter.txt
  llvm/utils/FileCheck/FileCheck.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82203.273059.patch
Type: text/x-patch
Size: 43769 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200624/72f424cb/attachment.bin>