[PATCH] D81236: Improve LegacyPassManager API to correctly report modified status

[serge via Phabricator via llvm-commits]

serge-sans-paille added a comment.

> I think this is the existing behavior and I'm reluctant to define it after years to be invalid without a really good reason (and it's the old PM so it might not be worth it).

It is the existing behavior and it's actively used.

> 
> 
>> //and// we don't want to update all callers of `getAnalysis` to expect a `std::pair<AnalysisType &, bool>` result, then your changes look good to me.
> 
> If we assume >95% not using the ID version to get a transformation, I think this is less churn for upstream and downstream users.

That was my initial idea.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81236/new/

https://reviews.llvm.org/D81236