[PATCH] D81236: Improve LegacyPassManager API to correctly report modified status

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D81236#2108372 <https://reviews.llvm.org/D81236#2108372>, @foad wrote:

> //If// we're happy that `getAnalysis` can cause changes,


I think this is the existing behavior and I'm reluctant to define it after years to be invalid without a really good reason (and it's the old PM so it might not be worth it).

> //and// we don't want to update all callers of `getAnalysis` to expect a `std::pair<AnalysisType &, bool>` result, then your changes look good to me.

If we assume >95% not using the ID version to get a transformation, I think this is less churn for upstream and downstream users.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81236/new/

https://reviews.llvm.org/D81236