[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

Puyan Lotfi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 24 02:07:55 PDT 2020


plotfi added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:4106
+    unsigned NumParts, MVT PartVT, Optional<CallingConv::ID> CC) const {
+  bool IsABIRegCopy = CC.hasValue();
+  EVT ValueVT = Val.getValueType();
----------------
I'm not well versed in arm CCs, but I suspect you might want this to check if the CC is arm_apcscc, arm_aapcscc, or arm_aapcs_vfpcc instead of checking merely if it has a CC. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75169/new/

https://reviews.llvm.org/D75169





More information about the llvm-commits mailing list