[PATCH] D82435: [DWARFYAML][debug_gnu_*] Add the missing context `IsGNUStyle`. NFC.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 24 02:07:53 PDT 2020


grimar added a comment.

Such approach generally feels unsafe. Should we instead introduce some struct, lets say `DWARFContext` which will be:

  struct DWARFContext {
    Optional<DWARFYAML::PubSection *> Section;
    Optional<bool> IsGNUStyle;
  }

so that we'll always know that `getContext` returns `DWARFContext*`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82435/new/

https://reviews.llvm.org/D82435





More information about the llvm-commits mailing list