[PATCH] D82435: [DWARFYAML][debug_gnu_*] Add the missing context `IsGNUStyle`. NFC.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 24 02:07:52 PDT 2020


jhenderson added a comment.

You need some form of testing for this. You might want to use Mach-O for testing it in this case.



================
Comment at: llvm/lib/ObjectYAML/DWARFYAML.cpp:59
+      DWARF.GNUPubTypes || !IO.outputting()) {
+    auto *OldContext = IO.getContext();
+    bool IsGNUStyle = false;
----------------
Let's be explicit about the type here. It's not obvious to me from looking at this what the type returned by `getContext` is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82435/new/

https://reviews.llvm.org/D82435





More information about the llvm-commits mailing list