[PATCH] D82401: [NFC] Remove assert from SelectionDAG::getZeroExtendInReg

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 23 19:59:36 PDT 2020


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1177
          "Vector element counts must match in getZeroExtendInReg");
   assert(VT.bitsLE(OpVT) && "Not extending!");
   if (OpVT == VT)
----------------
This bitLE check doesn't check what its intending to check if VT is a scalar and OpVT is a vector.  Should probably check the bits of the scalar type.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82401/new/

https://reviews.llvm.org/D82401





More information about the llvm-commits mailing list