[llvm] 59f45a1 - Mark some LLVM tests which require a default_triple (NFC)

[Mehdi AMINI via llvm-commits]

Hey,

Thanks for the catch! I fixed it in
https://github.com/llvm/llvm-project/commit/8b64adb0a285 hopefully

-- 
Mehdi


On Tue, Jun 23, 2020 at 8:21 AM Robinson, Paul <paul.robinson at sony.com>
wrote:

> Hi Mehdi,
> I tried sending this yesterday but I'm not sure it went through.
> I see the Go test was fixed to use default_triple, but the
> Kaleidoscope tests were changed to use default_target.  Was that
> intentional?  I don't see default_target used anywhere else.
> Thanks,
> --paulr
>
> > -----Original Message-----
> > From: llvm-commits <llvm-commits-bounces at lists.llvm.org> On Behalf Of
> > Mehdi Amini via llvm-commits
> > Sent: Friday, June 19, 2020 2:37 AM
> > To: llvm-commits at lists.llvm.org
> > Subject: [llvm] 59f45a1 - Mark some LLVM tests which require a
> > default_triple (NFC)
> >
> >
> > Author: Mehdi Amini
> > Date: 2020-06-19T06:36:20Z
> > New Revision: 59f45a1cdb361b2a6f6e75fad6d3055a1b7f9602
> >
> > URL: https://github.com/llvm/llvm-
> > project/commit/59f45a1cdb361b2a6f6e75fad6d3055a1b7f9602
> > DIFF: https://github.com/llvm/llvm-
> > project/commit/59f45a1cdb361b2a6f6e75fad6d3055a1b7f9602.diff
> >
> > LOG: Mark some LLVM tests which require a default_triple (NFC)
> >
> > These tests involve a JIT, and like other tests should have the
> > REQUIRE: default_triple present.
> > This allow to run `ninja check` without the host target configured
> > in.
> >
> > Added:
> >
> >
> > Modified:
> >     llvm/test/Bindings/Go/go.test
> >     llvm/test/Examples/Kaleidoscope/Chapter4.test
> >     llvm/test/Examples/Kaleidoscope/Chapter5.test
> >     llvm/test/Examples/Kaleidoscope/Chapter6.test
> >     llvm/test/Examples/Kaleidoscope/Chapter7.test
> >
> > Removed:
> >
> >
> >
> >
> ##########################################################################
> > ######
> > diff  --git a/llvm/test/Bindings/Go/go.test
> > b/llvm/test/Bindings/Go/go.test
> > index bb39e6c8455c..2d31c2790697 100644
> > --- a/llvm/test/Bindings/Go/go.test
> > +++ b/llvm/test/Bindings/Go/go.test
> > @@ -1,4 +1,4 @@
> >  ; RUN: llvm-go test llvm.org/llvm/bindings/go/llvm
> >
> > -; REQUIRES: shell
> > +; REQUIRES: shell, default_triple
> >  ; UNSUPPORTED: asan, ubsan, msan
> >
> > diff  --git a/llvm/test/Examples/Kaleidoscope/Chapter4.test
> > b/llvm/test/Examples/Kaleidoscope/Chapter4.test
> > index 5fd0e42c9a6d..7cc65216a0e7 100644
> > --- a/llvm/test/Examples/Kaleidoscope/Chapter4.test
> > +++ b/llvm/test/Examples/Kaleidoscope/Chapter4.test
> > @@ -1,4 +1,5 @@
> >  # RUN: Kaleidoscope-Ch4 < %s 2>&1 | FileCheck %s
> > +# REQUIRES: default_target
> >
> >  # Test basic definition, binding, and execution.
> >  def foo(x) x + 1;
> >
> > diff  --git a/llvm/test/Examples/Kaleidoscope/Chapter5.test
> > b/llvm/test/Examples/Kaleidoscope/Chapter5.test
> > index 1ad902378edb..b22633874fd0 100644
> > --- a/llvm/test/Examples/Kaleidoscope/Chapter5.test
> > +++ b/llvm/test/Examples/Kaleidoscope/Chapter5.test
> > @@ -1,4 +1,5 @@
> >  # RUN: Kaleidoscope-Ch5 < %s 2>&1 | FileCheck %s
> > +# REQUIRES: default_target
> >
> >  # Test 'if' expression.
> >  def foo(x) if x < 10 then 0 else 1;
> > @@ -16,4 +17,4 @@ for i = 1, i < 5, 1.0 in
> >  # CHECK: 3.0
> >  # CHECK: 4.0
> >  # CHECK: 5.0
> > -# CHECK: Evaluated to 0.000000
> > \ No newline at end of file
> > +# CHECK: Evaluated to 0.000000
> >
> > diff  --git a/llvm/test/Examples/Kaleidoscope/Chapter6.test
> > b/llvm/test/Examples/Kaleidoscope/Chapter6.test
> > index cbdd01f52683..57d8eae9f29c 100644
> > --- a/llvm/test/Examples/Kaleidoscope/Chapter6.test
> > +++ b/llvm/test/Examples/Kaleidoscope/Chapter6.test
> > @@ -1,4 +1,5 @@
> >  # RUN: Kaleidoscope-Ch6 < %s 2>&1 | FileCheck %s
> > +# REQUIRES: default_target
> >
> >  # Test unary operator definition.
> >  def unary-(x) 0 - x;
> >
> > diff  --git a/llvm/test/Examples/Kaleidoscope/Chapter7.test
> > b/llvm/test/Examples/Kaleidoscope/Chapter7.test
> > index 4843ca703aed..75d20ae756af 100644
> > --- a/llvm/test/Examples/Kaleidoscope/Chapter7.test
> > +++ b/llvm/test/Examples/Kaleidoscope/Chapter7.test
> > @@ -1,4 +1,5 @@
> >  # RUN: Kaleidoscope-Ch7 < %s 2>&1 | FileCheck %s
> > +# REQUIRES: default_target
> >
> >  # Sequence operator and iterative fibonacci function to test user
> defined
> > vars.
> >  def binary : 1 (x y) y;
> >
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200623/fb756712/attachment.html>