<div dir="ltr"><div dir="ltr">Hey,<div><br></div><div>Thanks for the catch! I fixed it in <a href="https://github.com/llvm/llvm-project/commit/8b64adb0a285" target="_blank">https://github.com/llvm/llvm-project/commit/8b64adb0a285</a> hopefully</div><div><br></div><div>-- </div><div>Mehdi</div><div><br></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jun 23, 2020 at 8:21 AM Robinson, Paul <<a href="mailto:paul.robinson@sony.com" target="_blank">paul.robinson@sony.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">Hi Mehdi,<br>
I tried sending this yesterday but I'm not sure it went through.<br>
I see the Go test was fixed to use default_triple, but the<br>
Kaleidoscope tests were changed to use default_target.  Was that<br>
intentional?  I don't see default_target used anywhere else.<br>
Thanks,<br>
--paulr<br>
<br>
> -----Original Message-----<br>
> From: llvm-commits <<a href="mailto:llvm-commits-bounces@lists.llvm.org" target="_blank">llvm-commits-bounces@lists.llvm.org</a>> On Behalf Of<br>
> Mehdi Amini via llvm-commits<br>
> Sent: Friday, June 19, 2020 2:37 AM<br>
> To: <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> Subject: [llvm] 59f45a1 - Mark some LLVM tests which require a<br>
> default_triple (NFC)<br>
> <br>
> <br>
> Author: Mehdi Amini<br>
> Date: 2020-06-19T06:36:20Z<br>
> New Revision: 59f45a1cdb361b2a6f6e75fad6d3055a1b7f9602<br>
> <br>
> URL: <a href="https://github.com/llvm/llvm-" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-</a><br>
> project/commit/59f45a1cdb361b2a6f6e75fad6d3055a1b7f9602<br>
> DIFF: <a href="https://github.com/llvm/llvm-" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-</a><br>
> project/commit/59f45a1cdb361b2a6f6e75fad6d3055a1b7f9602.diff<br>
> <br>
> LOG: Mark some LLVM tests which require a default_triple (NFC)<br>
> <br>
> These tests involve a JIT, and like other tests should have the<br>
> REQUIRE: default_triple present.<br>
> This allow to run `ninja check` without the host target configured<br>
> in.<br>
> <br>
> Added:<br>
> <br>
> <br>
> Modified:<br>
>     llvm/test/Bindings/Go/go.test<br>
>     llvm/test/Examples/Kaleidoscope/Chapter4.test<br>
>     llvm/test/Examples/Kaleidoscope/Chapter5.test<br>
>     llvm/test/Examples/Kaleidoscope/Chapter6.test<br>
>     llvm/test/Examples/Kaleidoscope/Chapter7.test<br>
> <br>
> Removed:<br>
> <br>
> <br>
> <br>
> ##########################################################################<br>
> ######<br>
> diff  --git a/llvm/test/Bindings/Go/go.test<br>
> b/llvm/test/Bindings/Go/go.test<br>
> index bb39e6c8455c..2d31c2790697 100644<br>
> --- a/llvm/test/Bindings/Go/go.test<br>
> +++ b/llvm/test/Bindings/Go/go.test<br>
> @@ -1,4 +1,4 @@<br>
>  ; RUN: llvm-go test <a href="http://llvm.org/llvm/bindings/go/llvm" rel="noreferrer" target="_blank">llvm.org/llvm/bindings/go/llvm</a><br>
> <br>
> -; REQUIRES: shell<br>
> +; REQUIRES: shell, default_triple<br>
>  ; UNSUPPORTED: asan, ubsan, msan<br>
> <br>
> diff  --git a/llvm/test/Examples/Kaleidoscope/Chapter4.test<br>
> b/llvm/test/Examples/Kaleidoscope/Chapter4.test<br>
> index 5fd0e42c9a6d..7cc65216a0e7 100644<br>
> --- a/llvm/test/Examples/Kaleidoscope/Chapter4.test<br>
> +++ b/llvm/test/Examples/Kaleidoscope/Chapter4.test<br>
> @@ -1,4 +1,5 @@<br>
>  # RUN: Kaleidoscope-Ch4 < %s 2>&1 | FileCheck %s<br>
> +# REQUIRES: default_target<br>
> <br>
>  # Test basic definition, binding, and execution.<br>
>  def foo(x) x + 1;<br>
> <br>
> diff  --git a/llvm/test/Examples/Kaleidoscope/Chapter5.test<br>
> b/llvm/test/Examples/Kaleidoscope/Chapter5.test<br>
> index 1ad902378edb..b22633874fd0 100644<br>
> --- a/llvm/test/Examples/Kaleidoscope/Chapter5.test<br>
> +++ b/llvm/test/Examples/Kaleidoscope/Chapter5.test<br>
> @@ -1,4 +1,5 @@<br>
>  # RUN: Kaleidoscope-Ch5 < %s 2>&1 | FileCheck %s<br>
> +# REQUIRES: default_target<br>
> <br>
>  # Test 'if' expression.<br>
>  def foo(x) if x < 10 then 0 else 1;<br>
> @@ -16,4 +17,4 @@ for i = 1, i < 5, 1.0 in<br>
>  # CHECK: 3.0<br>
>  # CHECK: 4.0<br>
>  # CHECK: 5.0<br>
> -# CHECK: Evaluated to 0.000000<br>
> \ No newline at end of file<br>
> +# CHECK: Evaluated to 0.000000<br>
> <br>
> diff  --git a/llvm/test/Examples/Kaleidoscope/Chapter6.test<br>
> b/llvm/test/Examples/Kaleidoscope/Chapter6.test<br>
> index cbdd01f52683..57d8eae9f29c 100644<br>
> --- a/llvm/test/Examples/Kaleidoscope/Chapter6.test<br>
> +++ b/llvm/test/Examples/Kaleidoscope/Chapter6.test<br>
> @@ -1,4 +1,5 @@<br>
>  # RUN: Kaleidoscope-Ch6 < %s 2>&1 | FileCheck %s<br>
> +# REQUIRES: default_target<br>
> <br>
>  # Test unary operator definition.<br>
>  def unary-(x) 0 - x;<br>
> <br>
> diff  --git a/llvm/test/Examples/Kaleidoscope/Chapter7.test<br>
> b/llvm/test/Examples/Kaleidoscope/Chapter7.test<br>
> index 4843ca703aed..75d20ae756af 100644<br>
> --- a/llvm/test/Examples/Kaleidoscope/Chapter7.test<br>
> +++ b/llvm/test/Examples/Kaleidoscope/Chapter7.test<br>
> @@ -1,4 +1,5 @@<br>
>  # RUN: Kaleidoscope-Ch7 < %s 2>&1 | FileCheck %s<br>
> +# REQUIRES: default_target<br>
> <br>
>  # Sequence operator and iterative fibonacci function to test user defined<br>
> vars.<br>
>  def binary : 1 (x y) y;<br>
> <br>
> <br>
> <br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>