[PATCH] D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 23 09:37:37 PDT 2020


StephenTozer marked an inline comment as done.
StephenTozer added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineInstr.cpp:2146
+                                               Register SpillReg) {
+  // VAR_DV_REFACTOR is this check necessary? all the callers need to check
+  // this themselves anyway, now that the logic is more tedious we might not
----------------
probinson wrote:
> Is this a note to yourself that should be removed?
Yes, along with the one below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82363/new/

https://reviews.llvm.org/D82363





More information about the llvm-commits mailing list