[PATCH] D82363: [DebugInfo] Add new instruction and expression operator for variadic debug values

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

In D82363#2108840 <https://reviews.llvm.org/D82363#2108840>, @StephenTozer wrote:

> In D82363#2108817 <https://reviews.llvm.org/D82363#2108817>, @djtodoro wrote:
>
> > `DBG_VAL_VAR` stands for //variadic//, any alternative for the name? //VAR// may indicate to '//variable//' I think...
>
>
> DBG_VALUE_VARIADIC seems reasonable though also quite long, but it's better than being misleading.


DBG_VALUE_LIST?  And the predicates could be `isDebugValueList` and `isSimpleDebugValue` or something along those lines.



================
Comment at: llvm/lib/CodeGen/MachineInstr.cpp:2146
+                                               Register SpillReg) {
+  // VAR_DV_REFACTOR is this check necessary? all the callers need to check
+  // this themselves anyway, now that the logic is more tedious we might not
----------------
Is this a note to yourself that should be removed?


================
Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1225
+
+        // VAR_DV_REFACTOR double check at the end of this, are multiple places
+        // performing this "add ops to deref the frame index" step?
----------------
Is this a note to yourself that should be removed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82363/new/

https://reviews.llvm.org/D82363