[PATCH] D79747: Implementation of Simple Outliner Module Pass

[Kamau Bridgeman via Phabricator via llvm-commits]

kamaub planned changes to this revision.
kamaub added a reviewer: fhahn.
kamaub added a comment.

In D79747#2072011 <https://reviews.llvm.org/D79747#2072011>, @fhahn wrote:

> I think it would be great to add more details about the benefit of the outlining to the description. For the example in the test case, outlining seems quite heavy handed. Wouldn't it be simpler and faster in those cases to just duplicate the return block?


Thank you for suggestion, this is an initial implementation so we handled the specific general case as duplicating the return block would not always be possible, I will post a motivating test case to show this and we can continue to discuss, but that won't be possible immediately.

I am marking this patch for changes planned; we see degradations in performance in particularly concerning areas that need to be investigated and addressed before we move forward.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79747/new/

https://reviews.llvm.org/D79747