[PATCH] D78663: [builtins] Add 32-bit shift builtins

[Ayke via Phabricator via llvm-commits]

aykevl updated this revision to Diff 272721.
aykevl added a comment.

- Changed `__inline` to `inline`
- Put `REQUIRES` line at the top

I'm not so sure about moving to an array of arrays. Coming from a Go background I'm used to this pattern (called "table driven tests") and I normally prefer it, but this pattern is rarely used in compiler-rt builtin tests and in particular is not used in the 64-bit versions of these tests (from which the 32-bit tests were derived: they are essentially the same tests but with shortened inputs).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78663/new/

https://reviews.llvm.org/D78663

Files:
  compiler-rt/lib/builtins/CMakeLists.txt
  compiler-rt/lib/builtins/ashldi3.c
  compiler-rt/lib/builtins/ashlsi3.c
  compiler-rt/lib/builtins/ashlti3.c
  compiler-rt/lib/builtins/ashrdi3.c
  compiler-rt/lib/builtins/ashrsi3.c
  compiler-rt/lib/builtins/ashrti3.c
  compiler-rt/lib/builtins/int_ashl_impl.inc
  compiler-rt/lib/builtins/int_ashr_impl.inc
  compiler-rt/lib/builtins/int_lshr_impl.inc
  compiler-rt/lib/builtins/int_types.h
  compiler-rt/lib/builtins/lshrdi3.c
  compiler-rt/lib/builtins/lshrsi3.c
  compiler-rt/lib/builtins/lshrti3.c
  compiler-rt/test/builtins/Unit/ashlsi3_test.c
  compiler-rt/test/builtins/Unit/ashrsi3_test.c
  compiler-rt/test/builtins/Unit/lshrsi3_test.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78663.272721.patch
Type: text/x-patch
Size: 23818 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200623/dbe0622f/attachment-0001.bin>