[PATCH] D81907: [llvm-objcopy] Fix help text

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:403
 static void printHelp(const opt::OptTable &OptTable, raw_ostream &OS,
-                      StringRef ToolName) {
-  OptTable.PrintHelp(OS, (ToolName + " input [output]").str().c_str(),
+                      StringRef ToolName, ToolType ToolEnum) {
+  StringRef HelpText;
----------------
alexshap wrote:
> nit: ToolType ToolEnum -> ToolType Tool
> 
> ToolName can be derived from ToolType, we probably don't need to pass it as an argument.
> 
> 
How would you and others feel about passing in the real executable name and printing that instead? It was an idea I had, but didn't suggest it before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81907/new/

https://reviews.llvm.org/D81907