[PATCH] D81907: [llvm-objcopy] Fix help text

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 22 18:17:37 PDT 2020


alexshap requested changes to this revision.
alexshap added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:403
 static void printHelp(const opt::OptTable &OptTable, raw_ostream &OS,
-                      StringRef ToolName) {
-  OptTable.PrintHelp(OS, (ToolName + " input [output]").str().c_str(),
+                      StringRef ToolName, ToolType ToolEnum) {
+  StringRef HelpText;
----------------
nit: ToolType ToolEnum -> ToolType Tool

ToolName can be derived from ToolType, we probably don't need to pass it as an argument.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81907/new/

https://reviews.llvm.org/D81907





More information about the llvm-commits mailing list