[PATCH] D81894: [llvm-readobj][COFF] add .llvm.call-graph-profile section dump

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

A few minor comments for the new test, otherwise we're basically there.



================
Comment at: llvm/test/tools/llvm-readobj/COFF/call-graph-profile-err.s:1
+# RUN: llvm-mc -filetype=obj -triple x86_64-pc-win32 %s -o %t
+# RUN: not llvm-readobj %t --cg-profile 2>&1 | FileCheck --check-prefix=ERR %s
----------------
Please add a comment somewhere in this file that explains the nature of the error this test case is testing, and how it does that.


================
Comment at: llvm/test/tools/llvm-readobj/COFF/call-graph-profile-err.s:6
+
+    .section .test
+a:
----------------
You indent this line, but not the other `.section` directive. You should do both.


================
Comment at: llvm/test/tools/llvm-readobj/COFF/call-graph-profile-err.s:14-16
+.long 10
+.long 11
+.byte 32
----------------
Please add some comments explaining what each of these values represent.


================
Comment at: llvm/test/tools/llvm-readobj/COFF/call-graph-profile-err.s:17
+.byte 32
\ No newline at end of file

----------------
Nit: no new line at EOF.


================
Comment at: llvm/test/tools/llvm-readobj/COFF/call-graph-profile.s:22
+
+    .section .test
+a:
----------------
Same as other test - inconsistent indentation.


================
Comment at: llvm/test/tools/llvm-readobj/COFF/call-graph-profile.s:41
+.quad 20    # weight from d to e
\ No newline at end of file

----------------
Nit: no new line at EOF.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81894/new/

https://reviews.llvm.org/D81894