[PATCH] D81894: [llvm-readobj][COFF] add .llvm.call-graph-profile section dump

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 23 01:01:02 PDT 2020


grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/COFF/call-graph-profile-err.s:1
+# RUN: llvm-mc -filetype=obj -triple x86_64-pc-win32 %s -o %t
+# RUN: not llvm-readobj %t --cg-profile 2>&1 | FileCheck --check-prefix=ERR %s
----------------
jhenderson wrote:
> Please add a comment somewhere in this file that explains the nature of the error this test case is testing, and how it does that.
I guess you also need `# REQUIRES: x86` on the first line here and in other test case, since llvm-mc is used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81894/new/

https://reviews.llvm.org/D81894





More information about the llvm-commits mailing list