[PATCH] D82293: [CodeMoverUtils][WIP] Move code motion related checks from LICM to CodeMoverUtils

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea requested changes to this revision.
asbirlea added a comment.
This revision now requires changes to proceed.

Thank you for the patch!

This needs to be split up into multiple changes, there's too much going on in this patch to review as is.

Cleaning up the utilities, adding const, clang-format are all awesome and straight-forward to review. They should be separate NFCs.

Adding those dependencies (PDT and DepAnalysis) are not correct in this format, in particular in the loop pass manager. The implication there is that *all* loop passes in *any* loop pipeline are guaranteed to preserve those analyses. At least for PDT,  I know that's not the case. I'm not familiar with DepAnalysis, but it looks like its scope overlaps with MemorySSA.
The constraints are different for Loop vs Function passes (LICM is a loop pass, LoopVectorize is a function pass), so again, the changes need to be reviewed separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82293/new/

https://reviews.llvm.org/D82293