[PATCH] D82293: [CodeMoverUtils][WIP] Move code motion related checks from LICM to CodeMoverUtils

[Bardia Mahjour via Phabricator via llvm-commits]

bmahjour added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/LoopUtils.h:200
+/// inherited
+///                                  from the original loop. The following
+///                                  values are considered:
----------------
fix formatting


================
Comment at: llvm/lib/Transforms/Utils/CodeMoverUtils.cpp:333
 bool llvm::isSafeToMoveBefore(Instruction &I, Instruction &InsertPoint,
-                              DominatorTree &DT, const PostDominatorTree &PDT,
                               DependenceInfo &DI) {
----------------
query functions should not change the dominator trees. why const is being removed here?


================
Comment at: llvm/lib/Transforms/Utils/CodeMoverUtils.cpp:413
 bool llvm::isSafeToMoveBefore(BasicBlock &BB, Instruction &InsertPoint,
-                              DominatorTree &DT, const PostDominatorTree &PDT,
                               DependenceInfo &DI) {
----------------
why const is dropped?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82293/new/

https://reviews.llvm.org/D82293