[PATCH] D77029: Fix out-of-bounds BitVector access in RegScavenger

[Eli Friedman via Phabricator via llvm-commits]

efriedma added reviewers: efriedma, arsenm.
efriedma added a comment.
Herald added a subscriber: wdng.

Oh, I see what you mean; if you assert that the access is in bounds, it asserts, but otherwise you can't show it actually misbehaves.

Really, there are only three operations involving TmpRegUnits; clear(), set(), and operator|=().  The sum result, I think, is that the operator|=() does nothing at all.

Given the code is currently "dead", this change is essentially adding new functionality. I don't want to do that without appropriate tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77029/new/

https://reviews.llvm.org/D77029